This repository has been archived by the owner on Jan 23, 2025. It is now read-only.
fix(opa): Continue upon filter fs errors #1369
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simar7
force-pushed
the
continue-opa-errors-2
branch
from
c4bbf16 to
367b32a
Compare
When loading custom data on Windows, if any errors occurs while parsing files on the filesystem, the associated logic fails to continue. Signed-off-by: Simar <[email protected]>
Signed-off-by: Simar <[email protected]>
simar7
force-pushed
the
continue-opa-errors-2
branch
from
bd7332b to
97c42ca
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When loading custom data, if any errors occurs while parsing files on the filesystem the associated logic fails to continue.
Current behaviour makes it so that any errors, we stop processing. This is too restrictive and can be changed to rather not filter upon errors and allow the files within the
dataFSto be processed normally.Signed-off-by: Simar [email protected]