Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

fix(cloudformation): fix panic when use pseudo-parameters NoValue or NotificationARNs #1395

Merged
merged 3 commits into from
Jul 20, 2023
Merged

fix(cloudformation): fix panic when use pseudo-parameters NoValue or NotificationARNs #1395

merged 3 commits into from
Jul 20, 2023

Conversation

nikpivkin
Copy link
Collaborator

@nikpivkin nikpivkin commented Jul 18, 2023 •
edited
Loading

Some pseudo-parameters are not strings, so when a parameter is cast to a string, panic occurs. Also, the values of the AWS::NotificationARNs parameter must be properties, not strings, to be able to use with Select or Join functions.

See aquasecurity/trivy#4843

@nikpivkin nikpivkin marked this pull request as ready for review July 18, 2023 07:14
@nikpivkin nikpivkin requested review from giorod3 and simar7 as code owners July 18, 2023 07:14
@simar7
Copy link
Member

simar7 commented Jul 19, 2023

do we have an issue in trivy/defsec which this fixes?

@nikpivkin
Copy link
Collaborator Author

@simar7 I opened an issue

@simar7 simar7 enabled auto-merge (squash) July 20, 2023 12:02
@simar7 simar7 merged commit 9046b67 into aquasecurity:master Jul 20, 2023
@simar7 simar7 mentioned this pull request Jul 20, 2023
Closed
@nikpivkin nikpivkin deleted the nik-pseudo-p branch July 20, 2023 16:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@simar7 simar7 simar7 approved these changes

@giorod3 giorod3 Awaiting requested review from giorod3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nikpivkin @simar7