Skip to content
This repository has been archived by the owner on Jan 23, 2025. It is now read-only.

feat: add support for AWS VPN client_login_banner_options #1513

Closed

Conversation

gantta
Copy link

@gantta gantta commented Jan 4, 2024

in support of aquasecurity/trivy#5863, adding functionality to support the handling of the Terraform resource aws_ec2_client_vpn_endpoint and checks for missing client_login_banner_options argument.

@gantta gantta requested a review from simar7 as a code owner January 4, 2024 11:56
@CLAassistant
Copy link

CLAassistant commented Jan 4, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@simar7 simar7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, could you resolve the merge conflicts?

Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Stale issues will be closed within 7 days of this label being assigned label Feb 14, 2024
@gantta
Copy link
Author

gantta commented Feb 14, 2024

similar to #1514 (comment), waiting for project refactor to be complete until we move forward with implementing this PR.

@github-actions github-actions bot removed the stale Stale issues will be closed within 7 days of this label being assigned label Feb 15, 2024
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Stale issues will be closed within 7 days of this label being assigned label Mar 16, 2024
@gantta
Copy link
Author

gantta commented Mar 19, 2024

moving changes to trivvy repo

@github-actions github-actions bot removed the stale Stale issues will be closed within 7 days of this label being assigned label Mar 19, 2024
Copy link

This PR is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 10 days.

@github-actions github-actions bot added the stale Stale issues will be closed within 7 days of this label being assigned label Apr 18, 2024
@simar7 simar7 closed this Apr 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
stale Stale issues will be closed within 7 days of this label being assigned
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants