This repository has been archived by the owner on Jan 23, 2025. It is now read-only.
feat: distinguish failed and ignored for JUnit (#719) #879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously all not passed scan results were treated as a failure by the JUnit formatter. This was a problem for e.g. tfsec, since with a JUnit result viewer there was no way to distinguish between ignored tests and actually failed ones. Now "ignored" scan results are marked as "skipped". Additionally, a test for passed scans has been added as well. It already worked as intended, but so far we had no test to ensure this.
|
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously all not passed scan results were treated as a failure by the
JUnit formatter. This was a problem for e.g. tfsec, since with a JUnit
result viewer there was no way to distinguish between ignored tests and
actually failed ones.
Now "ignored" scan results are marked as "skipped".
Additionally, a test for passed scans has been added as well. It already
worked as intended, but so far we had no test to ensure this.