Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(misconf): support for ignoring by inline comments for Dockerfile #8115

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

nikpivkin
Copy link
Contributor

@nikpivkin nikpivkin commented Dec 17, 2024

Description

Example config:

FROM scratch

# trivy:ignore:AVD-DS-0022
MAINTAINER [email protected]

Before:

❯ trivy conf Dockerfile.dev |grep "AVD-DS-0022"
2024-12-17T18:12:25+06:00       INFO    [misconfig] Misconfiguration scanning is enabled
2024-12-17T18:12:26+06:00       INFO    Detected config files   num=1
AVD-DS-0022 (HIGH): MAINTAINER should not be used: 'MAINTAINER [email protected]'

After:

❯ ./trivy conf Dockerfile.dev |grep "AVD-DS-0022"
2024-12-17T18:12:14+06:00       INFO    [misconfig] Misconfiguration scanning is enabled
2024-12-17T18:12:15+06:00       INFO    Detected config files   num=1

Related issues

Checklist

  • I've read the guidelines for contributing to this repository.
  • I've followed the conventions in the PR title.
  • I've added tests that prove my fix is effective or that my feature works.
  • I've updated the documentation with the relevant information (if needed).
  • I've added usage information (if the PR introduces new options)
  • I've included a "before" and "after" example to the description (if the PR is a user interface change).

@nikpivkin nikpivkin marked this pull request as ready for review January 17, 2025 06:30
@nikpivkin nikpivkin requested a review from simar7 as a code owner January 17, 2025 06:30
@simar7 simar7 added this pull request to the merge queue Jan 18, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 18, 2025
@simar7 simar7 added this pull request to the merge queue Jan 20, 2025
Merged via the queue into aquasecurity:main with commit c002327 Jan 20, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feat(misconf): support for ignoring by inline comments for Dockerfile
2 participants