chore: enable all rules from perfsprint #8194
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
requested review from
afdesk,
simar7,
nikpivkin,
knqyf263 and
DmitriyLewen
as code owners
mmorel-35
force-pushed
the
perfsprint/strconcat
branch
from
8d1f7a7 to
be6aebd
Compare
mmorel-35
changed the title
Signed-off-by: Matthieu MOREL <[email protected]>
mmorel-35
force-pushed
the
perfsprint/strconcat
branch
from
f3c8f15 to
7cefcc7
Compare
knqyf263
reviewed
Jan 6, 2025
| @@ -66,7 +66,7 @@ func TestRedisCache_PutArtifact(t *testing.T) { | |||
| addr = "dummy:16379" | |||
| } | |||
|
|
|||
| c, err := cache.NewRedisCache(fmt.Sprintf("redis://%s", addr), "", "", "", false, 0) | |||
| c, err := cache.NewRedisCache("redis://"+addr, "", "", "", false, 0) | |||
There was a problem hiding this comment.
I feel like it's too much. `fmt.Sprintf is easier to read than string concatenation, even with a performance downside. However, if it drastically improves performance, it's worth considering.
| # Optimizes into strings concatenation. | ||
| strconcat: false | ||
| strconcat: true |
There was a problem hiding this comment.
I personally prefer not to use this optimization.
Suggested change
| strconcat: true | |
| strconcat: false |
@DmitriyLewen @simar7 @nikpivkin However, if you prefer string concatenation, I'm okay with that.
There was a problem hiding this comment.
I would also vote not to use this. fmt.Sprintf seems fine to me. Is this subjective or there's something on the table w.r.t. performance by using this?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
enable and fixes all rules from perfsprint linter