Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixes device mapping in location_interpolation.py #81

Merged
merged 1 commit into from
Oct 25, 2024
Merged

Conversation

vkazei
Copy link
Contributor

@vkazei vkazei commented Oct 24, 2024

No description provided.

@ar4
Copy link
Owner

ar4 commented Oct 25, 2024

Hi Vladimir,

Thank you for this. The released version seems to use the location Tensor's device when the interpolator was created as the device for the weight Tensor, and then assumes that the device will be the same when the receiver method is called. I agree with you that adding a call to move it if necessary in the receiver method is a good idea.

I hope to do a large update of Deepwave around the end of the year, so I'll wait until then before making a new release that incorporates your change, if that is alright with you.

@ar4 ar4 merged commit 00798f8 into ar4:master Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants