Rebased version of #41 #47
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes issue #35. Also adds the `-unmute-ranks` option to disable this new behaviour.
Ideally only the muting would happen at the end of configuration, but there doesn't appear to be a hook for that.
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 27, 2023
47: Rebased version of #41 r=aragilar a=aragilar Replaces #41 in that the tests run and pass now. Hopefully this cases no breakage. Co-authored-by: Oliver Rausch <[email protected]> Co-authored-by: James Tocknell <[email protected]>
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 95.96% 96.52% +0.56%
==========================================
Files 3 3
Lines 124 144 +20
==========================================
+ Hits 119 139 +20
Misses 5 5
☔ View full report in Codecov by Sentry. |
|
Timed out. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #41 in that the tests run and pass now. Hopefully this cases no breakage.