Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: move and refactor subgraph #7

Merged
merged 44 commits into from
Mar 25, 2024
Merged

feat: move and refactor subgraph #7

merged 44 commits into from
Mar 25, 2024

Conversation

clauBv23
Copy link

@clauBv23 clauBv23 commented Mar 15, 2024 •
edited by jira bot
Loading

This PR moves the admin plugin subgraph from osx.

Task: OS-497

Subgraph link

jordaniza
jordaniza reviewed Mar 15, 2024
View reviewed changes
packages/subgraph/schema.graphql Outdated Show resolved Hide resolved
packages/subgraph/manifest/subgraph.placeholder.yaml Outdated Show resolved Hide resolved
packages/subgraph/schema.graphql Outdated Show resolved Hide resolved
packages/subgraph/schema.graphql Outdated Show resolved Hide resolved
packages/subgraph/schema.graphql Outdated Show resolved Hide resolved
packages/subgraph/schema.graphql Outdated Show resolved Hide resolved
packages/subgraph/src/osx/pluginSetupProcessor.ts Outdated Show resolved Hide resolved
@clauBv23 clauBv23 requested a review from jordaniza March 25, 2024 09:02
@clauBv23 clauBv23 marked this pull request as ready for review March 25, 2024 09:02
heueristik
heueristik suggested changes Mar 25, 2024
View reviewed changes
packages/subgraph/manifest/data/arbitrum.json Outdated Show resolved Hide resolved
packages/subgraph/manifest/data/baseGoerli.json Outdated Show resolved Hide resolved
packages/subgraph/manifest/subgraph.placeholder.yaml Outdated Show resolved Hide resolved
packages/subgraph/schema.graphql Outdated Show resolved Hide resolved
packages/subgraph/schema.graphql Show resolved Hide resolved
packages/subgraph/tests/plugin/plugin.test.ts Outdated Show resolved Hide resolved
jordaniza
jordaniza reviewed Mar 25, 2024
View reviewed changes
packages/subgraph/manifest/data/arbitrum.json Outdated Show resolved Hide resolved
packages/subgraph/schema.graphql Outdated Show resolved Hide resolved
packages/subgraph/src/plugin/admin.ts Outdated Show resolved Hide resolved
packages/subgraph/src/plugin/admin.ts Outdated Show resolved Hide resolved
packages/subgraph/src/plugin/adminMembers.ts Outdated Show resolved Hide resolved
packages/subgraph/src/plugin/adminMembers.ts Outdated Show resolved Hide resolved
packages/subgraph/tests/plugin/adminMembers.test.ts Outdated Show resolved Hide resolved
packages/subgraph/tests/plugin/adminMembers.test.ts Show resolved Hide resolved
clauBv23 and others added 15 commits March 25, 2024 13:08
@clauBv23
feat: update the manifest data json
da6095b
@clauBv23
ci: remove base goerli due to is deprecated
b4885c8
@clauBv23
feat: update the placeholder
6db495e
@clauBv23
feat: update the script to correctly get the plugin repo address
98edc23
@clauBv23
feat: rename admin ts file for plugin ts file
e516b13
@clauBv23
fix: update import
338938d
@clauBv23
fix: update import
ce2572b
@clauBv23 @heueristik
Update packages/subgraph/schema.graphql
858836d 
Co-authored-by: Michael Heuer <[email protected]>
@clauBv23 @heueristik
Update packages/subgraph/schema.graphql
5ee03f5 
Co-authored-by: Michael Heuer <[email protected]>
@clauBv23
feat: remove loop for iterate over a single element array list
fa02664
@clauBv23
ci: add comment for clarification
27f9499
@clauBv23
feat: create constant and move the execute proposal permission has
85cbd65
@clauBv23
feat: rename administrator related variables to be more clear
c444bb7
@clauBv23
feat: define variables for clarifying the usage in the code
b292034
@clauBv23
feat: use constant in test instead of magic expression
bbbb379
heueristik
heueristik previously approved these changes Mar 25, 2024
View reviewed changes
@clauBv23 clauBv23 requested a review from heueristik March 25, 2024 14:48
@clauBv23 clauBv23 merged commit f1cfcc1 into develop Mar 25, 2024
5 checks passed
@clauBv23 clauBv23 deleted the OS-497/move-and-refactor-subgraph branch March 25, 2024 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heueristik heueristik heueristik approved these changes

@Rekard0 Rekard0 Awaiting requested review from Rekard0

@josemarinas josemarinas Awaiting requested review from josemarinas

@jordaniza jordaniza Awaiting requested review from jordaniza

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@clauBv23 @Rekard0 @heueristik @jordaniza