Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New open.aragonpm script to deploy APM Registry #33

Merged
merged 11 commits into from
Apr 26, 2019

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Apr 22, 2019

close #10

I also move deployment scripts and logic from aragonOS.

@sohkai What you think is the best way to require necesary artifacts?

TODO:

  • release a beta version with open.aragonpm APM Registry deployed.

Note: Merging this PR will release a new stable version

Copy link
Contributor

@kernelwhisperer kernelwhisperer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a change to publish-apps and re-used the truffle config from aragonOS in 671cd45, what do you think?

scripts/deploy-apm-open.js Outdated Show resolved Hide resolved
scripts/deploy-apm.js Outdated Show resolved Hide resolved
@sohkai
Copy link
Contributor

sohkai commented Apr 23, 2019

What you think is the best way to require necessary artifacts?

Hmm, good question. Given that the scripts and the truffle dependency are in aragen, there might be two ways of doing this:

  1. After cloning aragonOS, go into it, truffle compile, and copy the build folder back into the root
  2. Don't even clone aragonOS, but add it as a dependency and use a mock import file (similar to e.g. https://github.com/aragon/aragon-apps/blob/master/apps/agent/contracts/test/TestImports.sol) so we can directly compile the necessary contracts (creating the build folder locally)

I think 2 is the cleanest option, especially since we'll be needing aragonOS as a dependency for its other extraneous utilities like the truffle config and deploy logger.

@0xGabi 0xGabi marked this pull request as ready for review April 23, 2019 22:30
@0xGabi 0xGabi requested a review from kernelwhisperer April 23, 2019 22:33
.travis.yml Outdated
@@ -2,9 +2,10 @@ language: node_js
notifications:
email: true
node_js:
- '8'
- '8'
install: travis_wait 30
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sohkai Is this the correct place for travis_wait flag? I want to extend the log output build error, was not sure about the specific place 🤔

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

travis_wait acts like a decorator, so you'll still need to provide the actual command to be run here (npm install).

However, I noticed there's only the prepublishOnly script defined, so I think the slow part is actually on npm publish as part of the deploy. Not sure if there's a way to tell travis not to timeout on that, but we may need to modify the scripts a bit so that we can run npm run start with the timeout and publish afterwards.

@0xGabi 0xGabi force-pushed the feat/open.aragonpm branch from ea05739 to a691749 Compare April 25, 2019 17:44
@0xGabi 0xGabi merged commit 10449a6 into aragon:master Apr 26, 2019
@0xGabi 0xGabi deleted the feat/open.aragonpm branch April 26, 2019 01:32

cd ../aragon-id;
cd repos/aragon-id;
echo "Deploying aragonID registry to aragonpm.eth"
npx truffle compile;
npx truffle exec --network rpc scripts/deploy-beta-aragonid.js;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now I'm starting to wonder if we should move the aragonID deployment script to here as well and just use @aragon/id as a dependency.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sense , so we have the same workflow for both

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deploy open.aragonpm.eth APM registry as part of gen
3 participants