-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New open.aragonpm script to deploy APM Registry #33
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added a change to publish-apps
and re-used the truffle config from aragonOS
in 671cd45
, what do you think?
Co-Authored-By: 0xGabi <[email protected]>
Hmm, good question. Given that the scripts and the truffle dependency are in
I think 2 is the cleanest option, especially since we'll be needing aragonOS as a dependency for its other extraneous utilities like the truffle config and deploy logger. |
.travis.yml
Outdated
@@ -2,9 +2,10 @@ language: node_js | |||
notifications: | |||
email: true | |||
node_js: | |||
- '8' | |||
- '8' | |||
install: travis_wait 30 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sohkai Is this the correct place for travis_wait
flag? I want to extend the log output build error, was not sure about the specific place 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
travis_wait
acts like a decorator, so you'll still need to provide the actual command to be run here (npm install
).
However, I noticed there's only the prepublishOnly
script defined, so I think the slow part is actually on npm publish
as part of the deploy. Not sure if there's a way to tell travis not to timeout on that, but we may need to modify the scripts a bit so that we can run npm run start
with the timeout and publish afterwards.
ea05739
to
a691749
Compare
|
||
cd ../aragon-id; | ||
cd repos/aragon-id; | ||
echo "Deploying aragonID registry to aragonpm.eth" | ||
npx truffle compile; | ||
npx truffle exec --network rpc scripts/deploy-beta-aragonid.js; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now I'm starting to wonder if we should move the aragonID deployment script to here as well and just use @aragon/id
as a dependency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make sense , so we have the same workflow for both
close #10
I also move deployment scripts and logic from aragonOS.
@sohkai What you think is the best way to require necesary artifacts?
TODO:
open.aragonpm
APM Registry deployed.Note: Merging this PR will release a new stable version