Update scripts & dependencies #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sohkai
reviewed
Jul 14, 2019
scripts/publish-client
Outdated
| set -e; | ||
| cd repos/aragon; | ||
|
|
||
| npm run publish:major -- --publish-dir $IPFS_CACHE/@aragon/aragon --skip-confirmation --no-propagate-content --no-build; |
There was a problem hiding this comment.
You'll want to use the build:local command instead
sohkai
reviewed
Aug 22, 2019
| "@aragon/id": "^2.0.0", | ||
| "@aragon/os": "^4.2.0", | ||
| "eth-ens-namehash": "^2.0.8", | ||
| "ganache-cli": "~6.2.0", | ||
| "ganache-cli": "^6.4.2", |
There was a problem hiding this comment.
@0xGabi It looks like this is actually breaking some assumptions we hold with ETH nodes :(.
The newer versions of ganache-cli do not seem to react properly to an eth_estimateGas, making transaction pathing in the client fail (it currently always says you can directly do every action).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #8 , closes #59 , closes #58 , closes #57, closes #62, closes #63
TODO: