Update ganache && fixes to devchain parametrization #79
Conversation
0xGabi
changed the title
| @@ -59,7 +59,7 @@ | |||
| "@aragon/os": "^4.2.0", | |||
| "@aragon/apps-shared-minime": "^1.0.0", | |||
| "eth-ens-namehash": "^2.0.8", | |||
| "ganache-cli": "~6.2.0", | |||
| "ganache-cli": "^6.7.0", | |||
There was a problem hiding this comment.
@0xGabi I remember us rolling back to 6.2.0 due to a forwarding bug; did we test that it was resolved on newer ganache-core versions?
Ahh... I see [email protected] has this exact fix :).
| @@ -66,16 +55,14 @@ exports.builder = yargs => { | |||
| default: false, | |||
| type: 'boolean', | |||
| description: 'Enable verbose devchain output', | |||
| alias: 'v', | |||
| alias: 'd', | |||
There was a problem hiding this comment.
Usually verbose is shortened to v; as well, this would constitute a major version change since it's part of the external API.
There was a problem hiding this comment.
Oh yes, I decide to include alias to have a similar syntax as ganache. Then I realize that there were a clash between the aragon --version alias and this alias on the devchain. What would be your suggestion in this case? Better not having the v alias on aragonCLI instead?
There was a problem hiding this comment.
Hmm, good question, the two might be mutually compatible, but confusing.
aragon -v
aragon devchain -v`
Of those two, I think aragon devchain -v is more important, and mirrors ganache-cli's flag.
We are not able to update the default balance of accounts once the snapshot was created (as far as I understood) as discussed here. There were some use cases reported by a user that he needed a higher amount of ETH so we have set 10,000 as initial balance in the snapshot.