Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Responsive voting app #617

Merged
merged 6 commits into from
Jan 25, 2019
Merged

Responsive voting app #617

merged 6 commits into from
Jan 25, 2019

Conversation

AquiGorka
Copy link
Contributor

@AquiGorka AquiGorka commented Jan 2, 2019 •
edited
Loading

@bpierre bpierre mentioned this pull request Jan 2, 2019
Closed
40 tasks
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 96.795% when pulling f91415a on feature/responsive-voting into 533b64c on feature/responsive-token-manager.

@coveralls
Copy link

coveralls commented Jan 2, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 96.124% when pulling 18a4d21 on feature/responsive-voting into fa6e646 on master.

luisivan
luisivan approved these changes Jan 7, 2019
View reviewed changes
Copy link
Contributor

@luisivan luisivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️

@sohkai sohkai modified the milestones: A1 Sprint: 3.1, A1 Sprint: 3.2 Jan 8, 2019
@AquiGorka AquiGorka force-pushed the feature/responsive-token-manager branch from 533b64c to 346c213 Compare January 15, 2019 11:10
@AquiGorka AquiGorka force-pushed the feature/responsive-voting branch from f91415a to 0a5e9ad Compare January 15, 2019 11:27
@AquiGorka AquiGorka changed the base branch from feature/responsive-token-manager to feature/responsive-menu-panel January 15, 2019 11:27
@AquiGorka AquiGorka requested review from sohkai, bpierre, izqui and delfipolito and removed request for jounih January 15, 2019 12:23
@AquiGorka AquiGorka changed the base branch from feature/responsive-menu-panel to master January 17, 2019 16:08
@AquiGorka AquiGorka force-pushed the feature/responsive-voting branch from 0a5e9ad to fc12ae1 Compare January 17, 2019 16:10
bpierre
bpierre reviewed Jan 18, 2019
View reviewed changes
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remarks than on #612, looking good otherwise!

apps/voting/app/src/App.js Outdated Show resolved Hide resolved
apps/voting/app/src/App.js Outdated Show resolved Hide resolved
@AquiGorka AquiGorka force-pushed the feature/responsive-voting branch from fc12ae1 to 0aa3f7e Compare January 18, 2019 08:41
@AquiGorka
Copy link
Contributor Author

Thank you @bpierre 😄 all comments addressed.

@AquiGorka AquiGorka mentioned this pull request Jan 21, 2019
Merged
@AquiGorka AquiGorka force-pushed the feature/responsive-voting branch from 0aa3f7e to 6469e32 Compare January 21, 2019 08:29
bpierre
bpierre approved these changes Jan 21, 2019
View reviewed changes
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One last last thing, we should have a minimum width:

image

All good for me otherwise ✅ ✅ ✅

@sohkai
Copy link
Contributor

sohkai commented Jan 22, 2019

@AquiGorka Also removed the title's right margin in 18a4d21 (although we can introduce it later when we figure out the title badges: #633).

@AquiGorka
Copy link
Contributor Author

@bpierre added the min-width suggestion.

@AquiGorka
Copy link
Contributor Author

@jounih the only thing stopping me from merging this PR is what you found on the margins between the cards but I'm not able to reproduce.

@AquiGorka AquiGorka force-pushed the feature/responsive-voting branch from 3f99edd to 516b6e4 Compare January 25, 2019 16:04
@AquiGorka AquiGorka merged commit 8b07003 into master Jan 25, 2019
@AquiGorka AquiGorka deleted the feature/responsive-voting branch January 25, 2019 16:06
@luisivan luisivan mentioned this pull request Mar 4, 2019
Closed
46 tasks
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@AquiGorka
Responsive voting app (aragon#617)
87a9b5f 
* Voting: add new vote button component

* Voting: use new vote button

* VotingCardGroup: add responsive behaviour

* VotePanelContent: add identity badge component

* Voting: remove unnecessary margin-right from app title

* Voting: add responsive min width
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sohkai sohkai sohkai left review comments

@bpierre bpierre bpierre approved these changes

@luisivan luisivan luisivan approved these changes

@izqui izqui Awaiting requested review from izqui

@delfipolito delfipolito Awaiting requested review from delfipolito

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
A1 Sprint: 3.2
Development

Successfully merging this pull request may close these issues.
5 participants
@AquiGorka @coveralls @sohkai @bpierre @luisivan