Voting: move to Viewport #672
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bpierre
commented
Feb 14, 2019
bpierre
commented
- Remove uses of BreakPoint.
- Moved the app layout structure into AppLayout.
- Moved the main action icon into an icon component.
- Remove uses of BreakPoint. - Moved the app layout structure into AppLayout. - Moved the main action icon into an icon component.
bpierre
requested review from
AquiGorka and
sohkai
and removed request for
AquiGorka
sohkai
approved these changes
Feb 15, 2019
| @@ -236,7 +230,7 @@ class VotePanelContent extends React.Component { | |||
| <Label>Created By</Label> | |||
| </h2> | |||
| <Creator> | |||
| <IdentityBadge entity={creator} shorten={shortAddresses} /> | |||
There was a problem hiding this comment.
Do we not need this to be shortened at all now?
There was a problem hiding this comment.
I think it could be shortened at all times (which is the default), now that it opens with the full address. /cc @aragon/design
There was a problem hiding this comment.
yeah I think the shortened version as default is good (for 0x addresses)
There was a problem hiding this comment.
Good point, that may actually make it easier to verify for most people (I assume most check 3-4 at the start and at the end), if they check at all.
AquiGorka
approved these changes
Feb 18, 2019
40 tasks
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
- Upgrade @aragon/ui to 0.31.0. - Move to Viewport (remove uses of BreakPoint). - Use Main. - Moved the app layout structure into a dedicated component, AppLayout. - Moved the main action icon into an icon component.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.