Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove unnecessary dependencies #817

Merged
merged 1 commit into from
Apr 18, 2019
Merged

Conversation

sohkai
Copy link
Contributor

@sohkai sohkai commented Apr 18, 2019

cc @facuspagnuolo

Hopefully this will get travis to run a bit faster with a lighter cache. Might be some other cache improvements we can make... somehow the cache on travis is yuge at 16GB:

Screen Shot 2019-04-18 at 9 22 53 AM

"solium": "^1.2.3",
"truffle": "4.1.14",
"truffle-extract": "^1.2.1",
"web3-eth-abi": "^1.0.0-beta.38",
"webpack": "3.10.0"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We used to have to pin webpack because the frontends relied on it and somehow there were version clashes with ganache (or something weird), but we've since moved to parcel and nothing should rely on webpack now.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 97.015% when pulling 68deed2 on reduce-dependencies into 0bf6ff4 on master.

@sohkai sohkai merged commit 5eb9872 into master Apr 18, 2019
@sohkai sohkai deleted the reduce-dependencies branch April 18, 2019 15:03
MickdeGraaf pushed a commit to MickdeGraaf/aragon-apps that referenced this pull request Jan 28, 2020
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants