Finance - use updated app API with caching and init #854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
originates from discssion in aragon/aragon.js#297 (comment)
2color
force-pushed
the
finance-use-init-api
branch
from
723f3bb to
8389410
Compare
sohkai
reviewed
May 27, 2019
sohkai
reviewed
May 27, 2019
sohkai
approved these changes
May 27, 2019
* Use cached state in init and use sync events * Render syncing state * Use exported events object from the api From e027fb419fa62a220034a248bc7c1d1271731519 * Finance: use the SyncIndicator component (#874) * Finance: use the SyncIndicator component * Finance: update @aragon/api dependencies * bump @aragon/api 2.0.0-beta.2 * Upgrade rxjs
sohkai
reviewed
May 29, 2019
| break | ||
| case events.SYNC_STATUS_SYNCED: | ||
| nextState.isSyncing = false | ||
| break |
There was a problem hiding this comment.
Small thing, could we lift these events out of the address check and do something similar to the Voting app?
ramilexe
pushed a commit
to ConsiderItDone/aragon-apps
that referenced
this pull request
Dec 9, 2021
* finance: use updated api to leverage caching * Add todo about a performance improvement originates from discssion in aragon/aragon.js#297 (comment) * Remove old TODO * Load all token balances on init * fixup! Load all token balances on init * Finance - app loading state (aragon#867) * Use cached state in init and use sync events * Render syncing state * Use exported events object from the api From e027fb419fa62a220034a248bc7c1d1271731519 * Finance: use the SyncIndicator component (aragon#874) * Finance: use the SyncIndicator component * Finance: update @aragon/api dependencies * bump @aragon/api 2.0.0-beta.2 * Upgrade rxjs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
INITIALIZATION_TRIGGERwith an init function (part of the new API)initializationBlockto the api to leverage cachingDependency PR