Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

voting: catch invalid script error #884

Merged
merged 4 commits into from
Jun 6, 2019
Merged

voting: catch invalid script error #884

merged 4 commits into from
Jun 6, 2019

Conversation

2color
Copy link
Contributor

@2color 2color commented Jun 6, 2019

What

  • Fix an an caught error which would crash the background script
  • The error was detected with the following newVote tx
  • Render votes with invalid scripts with an error message

Bug Example

@2color 2color requested review from bpierre, izqui and AquiGorka June 6, 2019 14:15
AquiGorka
AquiGorka approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@AquiGorka AquiGorka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌 🚀 Left a couple of questions

izqui
izqui approved these changes Jun 6, 2019
View reviewed changes
Copy link
Contributor

@izqui izqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 97.732% when pulling e692c1a on catch-invalid-script-error into 7d61235 on master.

@2color 2color merged commit 51e4800 into master Jun 6, 2019
@2color 2color deleted the catch-invalid-script-error branch June 6, 2019 16:12
ramilexe pushed a commit to ConsiderItDone/aragon-apps that referenced this pull request Dec 9, 2021
@2color
voting: catch invalid script error (aragon#884)
3dbf790 
* voting: catch invalid script error

* Use console.error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@izqui izqui izqui approved these changes

@AquiGorka AquiGorka AquiGorka approved these changes

@bpierre bpierre Awaiting requested review from bpierre

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@2color @coveralls @izqui @AquiGorka