Add timeout for starting IPFS and better error handling (#211)

* Add timeout for starting IPFS and better error handling

* Always migrate on IPFS daemon start to avoid user prompt

packages/aragon-cli/src/commands/ipfs.js

@@ -57,12 +57,17 @@ exports.task = ({ apmOptions }) => {
 exports.handler = function ({ reporter, apm: apmOptions }) {
   const task = exports.task({ apmOptions })
 
-  task.run().then(ctx => {
-    if (ctx.started) {
-      reporter.info('IPFS daemon is now running. Stopping this process will stop IPFS')
-    } else {
-      reporter.warning('Didnt start IPFS, port busy')
-      process.exit()
-    }
-  })
+  task.run()
+    .then(ctx => {
+      if (ctx.started) {
+        reporter.info('IPFS daemon is now running. Stopping this process will stop IPFS')
+      } else {
+        reporter.warning('Didnt start IPFS, port busy')
+        process.exit()
+      }
+    })
+    .catch(error => {
+        reporter.error(error.message)
+        process.exit()
+    })
 }

packages/aragon-cli/src/helpers/ipfs-daemon.js

@@ -9,19 +9,39 @@ const ipfsBin = getNPMBinary('go-ipfs', 'bin/ipfs')
 
 const ensureIPFSInitialized = async () => {
   if (!fs.existsSync(path.join(os.homedir(), '.ipfs'))) {
+    // We could use 'ipfs daemon --init' when https://github.com/ipfs/go-ipfs/issues/3913 is solved
     await execa(ipfsBin, ['init'])
   }
 }
 
-const startIPFSDaemon = () => (
-  new Promise(async (resolve) => {
+const startIPFSDaemon = () => {
+  const IPFS_START_TIMEOUT = 7500 // 7.5s for timeout, may need to be tweaked
+
+  let startOutput = ''
+
+  // We add a timeout as starting
+  const timeout = new Promise((resolve, reject) => {
+    setTimeout(() => {
+      reject(new Error(`Starting IPFS timed out:\n${startOutput}`))
+    }, IPFS_START_TIMEOUT)
+  })
+
+  const start = new Promise(async (resolve, reject) => {
     await ensureIPFSInitialized()
-    const ipfsProc = execa(ipfsBin, ['daemon'])
+    const ipfsProc = execa(ipfsBin, ['daemon', '--migrate'])
+
     ipfsProc.stdout.on('data', (data) => {
+      startOutput = `${startOutput}${data.toString()}\n`
       if (data.toString().includes('Daemon is ready')) resolve()
     })
+
+    ipfsProc.stderr.on('data', (data) => {
+      reject(new Error(`Starting IPFS failed: ${data.toString()}`))
+    })
   })
-)
+
+  return Promise.race([start, timeout])
+}
 
 let ipfsNode