Fix gasLimit issue for dao new (#361)

aragon · Feb 12, 2019 · a19932c · a19932c
1 parent 89f5ea5
commit a19932c
Show file tree

Hide file tree

Showing 11 changed files with 2,807 additions and 2,728 deletions.
diff --git a/Specification.md b/Specification.md
@@ -0,0 +1,17 @@
+## Gas limit
+
+By default `web3.js` uses `web3.eth.Contract.method.myMethod().estimateGas()`, but this value can differ from the 
+actual gas that will be used, if the contract you are calling depends on the blockhash, blocknumber or any other source of 
+randomness making the gas cost nondeterministic.
+
+E.g.: the [`MiniMeToken`](https://github.com/aragon/aragon-apps/blob/master/shared/minime/contracts/MiniMeToken.sol) contract which snapshots balances at certain block numbers.
+
+Considering the above-mentioned behavior, the CLI should calculate the recommended gas limit as follows:
+- `recommendedGas = estimatedGas`, if `estimatedGas > upperGasLimit` or
+- `recommendedGas = estimatedGas * DEFAULT_GAS_FUZZ_FACTOR` with a maximum value of `upperGasLimit`
+
+Where `upperGasLimit = latestBlock.gasLimit * LAST_BLOCK_GAS_LIMIT_FACTOR`, `DEFAULT_GAS_FUZZ_FACTOR = 1.5` and `LAST_BLOCK_GAS_LIMIT_FACTOR = 0.95`.
+
+See `src/util.js#getRecommendedGasLimit`. (This should probably be its own library)
+
+The CLI should ignore the `gas` property of the network from truffle config.