Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider if we should start ipfs on all needed commands #1192

Closed
0xGabi opened this issue Jan 9, 2020 · 2 comments · Fixed by #1208
Closed

Consider if we should start ipfs on all needed commands #1192

0xGabi opened this issue Jan 9, 2020 · 2 comments · Fixed by #1208
Assignees
@macor161
Labels
💡 feature update An update to existing functionality of the API
Milestone
Sprint 1

Comments

@0xGabi
Copy link
Contributor

0xGabi commented Jan 9, 2020 •
edited
Loading

During v7 refactor we remove all the checks that started the IPFS daemon if it was not detected.

Currently when running commands like dao install and there is no IPFS running we output:

Get Repo [started]
Get Repo [failed]
→ Cannot find artifacts in aragonPM repo. Please make sure the package is published and IPFS or your HTTP server running.
Fetching katalyst.open.aragonpm.eth@latest [failed]
→ Cannot find artifacts in aragonPM repo. Please make sure the package is published and IPFS or your HTTP server running.
✖ Error: Cannot find artifacts in aragonPM repo. Please make sure the package is published and IPFS or your HTTP server running.

We should consider if introduce again something like we add in aragon run here.
@0xGabi 0xGabi added the 💡 feature update An update to existing functionality of the API label Jan 9, 2020
@0xGabi 0xGabi added this to the Sprint 1 milestone Jan 9, 2020
@macor161
Copy link
Contributor

macor161 commented Jan 9, 2020

I would be interested to know what was the reasoning behind removing the start ipfs task from the commands but I would definitely add them back.

@macor161 macor161 self-assigned this Jan 9, 2020
@macor161 macor161 mentioned this issue Jan 15, 2020
Merged
1 task
@0xGabi
Copy link
Contributor Author

0xGabi commented Jan 23, 2020

@0x6431346e 👆

I think we thought having ipfs daemon always running was going to be the default 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@macor161 macor161

Labels
💡 feature update An update to existing functionality of the API
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging a pull request may close this issue.

Start the IPFS server in relevant commands aragon/aragon-cli
2 participants
@macor161 @0xGabi