Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start the IPFS server in relevant commands #1208

Merged
merged 8 commits into from
Jan 23, 2020
Merged

Start the IPFS server in relevant commands #1208

merged 8 commits into from
Jan 23, 2020

Conversation

macor161
Copy link
Contributor

@macor161 macor161 commented Jan 15, 2020 •
edited
Loading

🦅 Pull Request

Closes #1192

🚨 Test instructions

  • dao install
  • dao new
  • dao upgrade
  • aragon ipfs propagate
  • aragon ipfs view

To-do

  • Tests

@codecov
Copy link

codecov bot commented Jan 15, 2020 •
edited
Loading

Codecov Report

Merging #1208 into develop will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           develop   #1208   +/-   ##
=======================================
  Coverage       57%     57%           
=======================================
  Files          130     130           
  Lines         2307    2307           
=======================================
  Hits          1315    1315           
  Misses         992     992

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 82a2740...feaa33c. Read the comment docs.

@macor161 macor161 changed the title WIP Start the IPFS server in relevant commands Start the IPFS server in relevant commands Jan 17, 2020
@macor161
Copy link
Contributor Author

There seems to be something wrong with the coverage. packages/cli/src/commands/dao_cmds/new.js should have more than 0% 🤔

@0xGabi 0xGabi merged commit 426e4a1 into develop Jan 23, 2020
@0xGabi 0xGabi deleted the add-ipfs-check branch January 23, 2020 05:03
@0xGabi 0xGabi added the 💡 feature update An update to existing functionality of the API label Jan 23, 2020
@0xGabi 0xGabi added this to the Sprint 1 milestone Jan 23, 2020
@0xGabi 0xGabi mentioned this pull request Jan 23, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xGabi 0xGabi 0xGabi approved these changes

@kernelwhisperer kernelwhisperer Awaiting requested review from kernelwhisperer

Assignees

@macor161 macor161

Labels
💡 feature update An update to existing functionality of the API
Projects
None yet
Milestone
Sprint 1
Development

Successfully merging this pull request may close these issues.

Consider if we should start ipfs on all needed commands
2 participants
@macor161 @0xGabi