Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dao exec, dao act: fix support for string types in function arguments #369

Open
izqui opened this issue Feb 16, 2019 · 3 comments
Open

dao exec, dao act: fix support for string types in function arguments #369

izqui opened this issue Feb 16, 2019 · 3 comments
Assignees
Labels
πŸ› bug An unexpected behavior of the API πŸ™ good first issue An easy issue for a new contributor

Comments

@izqui
Copy link
Contributor

izqui commented Feb 16, 2019

Currently state:

  • string: even if using quotes, it will just use the first word and interpret everything after a space as a new argument.
  • bool: i haven't been able to find a value to send a false parameter
  • arrays: πŸ€·β€β™€οΈ
@kernelwhisperer
Copy link
Contributor

Related to #320

@kernelwhisperer
Copy link
Contributor

  • string: even if using quotes, it will just use the first word and interpret everything after a space as a new argument.

Can't figure this out either... but after checking this example:

#!/usr/bin/env node

var opts = require('yargs')
    .argv;

console.log(opts);

And seeing that either of these work:

'hello world'
"hello world"
hello\ world

I'm thinking it's something in our configuration/middle-wares πŸ€”

bool and array should work once #555 is merged

@0xGabi 0xGabi changed the title dao exec, dao act: fix support for string, bool and array types in function arguments dao exec, dao act: fix support for string types in function arguments Jul 6, 2019
@0xGabi 0xGabi added the πŸ™ good first issue An easy issue for a new contributor label Oct 21, 2019
@0xGabi 0xGabi mentioned this issue Oct 21, 2019
31 tasks
@0xGabi 0xGabi added this to the Sprint 2 milestone Jan 23, 2020
@eternauta1337 eternauta1337 removed this from the Sprint 2 milestone Jan 24, 2020
@eternauta1337 eternauta1337 added this to the Sprint 2 milestone Jan 24, 2020
@0xGabi
Copy link
Contributor

0xGabi commented Jan 24, 2020

Related to #1008

@0xGabi 0xGabi removed this from the Sprint 2 milestone Feb 8, 2020
@stale stale bot added the abandoned label Aug 6, 2020
@aragon aragon deleted a comment from stale bot Aug 6, 2020
@stale stale bot removed the abandoned label Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
πŸ› bug An unexpected behavior of the API πŸ™ good first issue An easy issue for a new contributor
Projects
None yet
Development

No branches or pull requests

6 participants