allow arrays to be passed via --app-init-params #623
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
web3.eth.abi.encodeFunctionCall expects a javascript array, which needs to be parse from the CLI input
mikec
added a commit
to levelkdev/oracle-manager-app
that referenced
this pull request
Jul 15, 2019
because of this issue in the CLI aragon/aragon-cli#623
0xGabi
approved these changes
Jul 31, 2019
There was a problem hiding this comment.
Thanks @mikec works great. We should explain as clear as possible on documentation how to use it. It took me a while to figure out 😅
For reference now arrays able to be passed like:
--app-init-args ["'0xB24b...73a7', '0xB24b...73a7'"]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
web3.eth.abi.encodeFunctionCall expects a javascript array, which needs to be parse from the CLI input
🦅 Pull Request
Closes #320
run command doesn't support arrays as --app-init-params
🚨 Test instructions
create a contract that takes an
address[]type as a param for theinitialize()function. Try executing run command with--app-init-params ["<address>"]