Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize every Aragon CLI download with it's own seed phrase #758

Closed
yeqbfgxjiq opened this issue Sep 9, 2019 · 7 comments · Fixed by #767
Closed

Initialize every Aragon CLI download with it's own seed phrase #758

yeqbfgxjiq opened this issue Sep 9, 2019 · 7 comments · Fixed by #767

Comments

@yeqbfgxjiq
Copy link
Contributor

💥 Proposal

AFAIK the Aragon CLI uses the same accounts from the same seed phrase for everyone. That's been fine mostly, but today I just tried to deploy a Rinkeby or and realized that the account was out of Rinkeby ETH. My first thought was, whatever I'll just add more. Then it dawned on me that actually anyone could take ownership of my DAO in the middle of my deployment. Even though it's just a Rinkeby test, this is still not good. It would be great if every download of the Aragon CLI came with a unique seed phrase.

@welcome
Copy link

welcome bot commented Sep 9, 2019

Thanks for opening your first issue in aragonCLI! Someone will circle back soon ⚡

@sohkai
Copy link
Contributor

sohkai commented Sep 11, 2019

I strongly oppose this, because it breaks the UX of how the bundled chain works (it comes with specific accounts holding permissions in already deployed repos / etc).

Rather, the CLI should prompt you to use your own web3 provider (whether that's a <network>_key.json file or Frame or etc) when it looks like you're going to do something on a public network.

@yeqbfgxjiq
Copy link
Contributor Author

yeqbfgxjiq commented Sep 11, 2019

Didn't know that would break the UX of the devchain package.

Your suggestion sounds great though as it would totally resolve the Issue. That would be awesome.

In addition, the docs on hack.aragon should have big bold warnings about the mnemonic seed phrase like the Truffle docs do

@pythonpete32
Copy link

pythonpete32 commented Sep 12, 2019

+1 on the cli prompt. It took me a while to figure out how private keys worked. This would really improve the UX.

Finding the .aragon file and creating a <network>_key.json manually is not really user-friendly. This is also compounded by the fact that .aragon is not created on install, you first have to run the devchain. This also dosn't make sense if you just want to interact with rinkeby or mainnet

@yeqbfgxjiq
Copy link
Contributor Author

@pythonpete32 Good point! Updated the CLI installation page with info on the .aragon and private key stuff #767

Would also be great if the CLI itself prompted users with this information (and/or if that info was accessible via the --help flag)

@0xGabi
Copy link
Contributor

0xGabi commented Sep 14, 2019

Thanks both @burrrata and @pythonpete32 great feedback. We are currently thinking about this issues and how a roadmap to tackle them looks like, but be sure that improving the web3 providers is in my top priorities right now

@0xGabi
Copy link
Contributor

0xGabi commented Sep 14, 2019

Also @pythonpete32 not sure if we already have an issue open for creating the ~/.aragon folder on installation. Would you mind to create one, otherwise? Thanks 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants