Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CLI Mnenmonic Warning #767

Merged
merged 3 commits into from
Sep 23, 2019
Merged

Added CLI Mnenmonic Warning #767

merged 3 commits into from
Sep 23, 2019

Conversation

yeqbfgxjiq
Copy link
Contributor

Added a placeholder warning regarding the Aragon CLI default mnemonic. Not sure if there's a guide on how to use your own signing key for the CLI (I think I saw one somewhere).

Does not close #758, but hopefully it helps.

Added a placeholder warning regarding the Aragon CLI default mnemonic. Not sure if there's a guide on how to use your own signing key for the CLI (I think I saw one somewhere).
@welcome
Copy link

welcome bot commented Sep 11, 2019

Thanks for opening this pull request! Someone will review it soon 🔍

@yeqbfgxjiq yeqbfgxjiq changed the title Update Intro.md Added CLI Mnenmonic Warning Sep 11, 2019
@0xGabi
Copy link
Contributor

0xGabi commented Sep 12, 2019

Thanks @burrrata. The the link you are looking for is: https://hack.aragon.org/docs/guides-faq#set-a-private-key

@yeqbfgxjiq
Copy link
Contributor Author

yeqbfgxjiq commented Sep 12, 2019

@0xGabi Thanks! Added the link and also copied the warning to the DAO commands page where people would be using the Aragon CLI to create DAOs. Currently the warning is on Intro.md and Dao-commands.md, but should it go on all the other docs too as a general warning?

@yeqbfgxjiq
Copy link
Contributor Author

Update: after discussing this further with @pythonpete32 we both A) needed to use the private key feature to actually deploy a DAO and B) were confused why it was so hard to find that info. Since the AragonCLI is meant to make it easy to deploy and build DAOs, it seems like setting it up to deploy to public networks should be a core part of the installation instructions. Copied the .aragon and private key info to the intro page and reworded the copy for better readability

@0xGabi
Copy link
Contributor

0xGabi commented Sep 23, 2019

This is much clear now! Thanks

@0xGabi 0xGabi merged commit c3569d6 into aragon:master Sep 23, 2019
@welcome
Copy link

welcome bot commented Sep 23, 2019

Congrats on merging your first pull request! Aragon is proud of you 🦅
Eagle gif

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initialize every Aragon CLI download with it's own seed phrase
2 participants