Patch to prevent long running commands to call onFinishCommand hook

[dapplion]

🦅 Pull Request

Fixes a regression introduced in #992 where commands that are supposed to run until the user stop them, stopped automatically.

• devchain_cmds/start.js
• start.js
• run.js

This patch will not be necessary once the onFinishCommand hook is removed, which should happen in a short-medium future.

🚨 Test instructions

Run

node dist/cli.js devchain

node dist/cli.js start

node dist/cli.js run

And the command should not finish after successful completion

✔️ PR Todo

• Include links to related issues/PRs
• Update unit tests for this change
• Update the relevant documentation
• Clear dependencies on other modules that have to be released before merging this

[codecov]

Codecov Report

Merging #1032 into develop will decrease coverage by 0.07%.
The diff coverage is 0%.

@@             Coverage Diff             @@
##           develop    #1032      +/-   ##
===========================================
- Coverage    26.43%   26.36%   -0.08%     
===========================================
  Files          124      124              
  Lines         2470     2481      +11     
===========================================
+ Hits           653      654       +1     
- Misses        1817     1827      +10

Impacted Files	Coverage Δ
...ges/aragon-cli/src/commands/devchain_cmds/start.js	0% <0%> (ø)	⬆️
packages/aragon-cli/src/commands/start.js	0% <0%> (ø)	⬆️
packages/aragon-cli/src/commands/run.js	0% <0%> (ø)	⬆️
packages/toolkit/src/ipfs/daemon.js	85.71% <0%> (ø)	⬆️
packages/toolkit/src/ipfs/misc.js	36.58% <0%> (+2.43%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec92a85...c204943. Read the comment docs.

[eternauta1337]

LGTM!