-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Run tests without subprocess and split tests and examples #1105
Conversation
const ensRegistryAddress = '0x5f6f7e8cc7346a11ca2def8f827b7a0b612c56a1' | ||
const options = { | ||
web3, | ||
provider: web3.eth.currentProvider, | ||
ipfs: { | ||
rpc: { protocol: 'http', host: 'localhost', port: 5001, default: true }, | ||
gateway: 'http://localhost:8080/ipfs', | ||
}, | ||
registryAddress: ensRegistryAddress, | ||
ensRegistryAddress, | ||
'ens-registry': ensRegistryAddress, | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
const ensRegistryAddress = '0x5f6f7e8cc7346a11ca2def8f827b7a0b612c56a1' | |
const options = { | |
web3, | |
provider: web3.eth.currentProvider, | |
ipfs: { | |
rpc: { protocol: 'http', host: 'localhost', port: 5001, default: true }, | |
gateway: 'http://localhost:8080/ipfs', | |
}, | |
registryAddress: ensRegistryAddress, | |
ensRegistryAddress, | |
'ens-registry': ensRegistryAddress, | |
} | |
const options = { | |
web3, | |
provider: web3.eth.currentProvider, | |
apm: { | |
ipfs: { | |
rpc: { protocol: 'http', host: 'localhost', port: 5001, default: true }, | |
gateway: 'http://localhost:8080/ipfs', | |
}, | |
ensRegistryAddress: '0x5f6f7e8cc7346a11ca2def8f827b7a0b612c56a1', | |
}, | |
} |
app: votingAddress, | ||
method: 'newVote', | ||
params: [script, 'Execute multiple votes'], | ||
apm: options, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
apm: options, | |
apm: options.apm, |
web3, | ||
'membership-template.aragonpm.eth', | ||
'latest', | ||
options |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
options | |
options.apm |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The option
object was a bit awkward. Also in the example only the apm
configuration was utilized. Do we want to remove the provider and web3? 🤔
@0xGabi I agree, the |
🦅 Pull Request
Builds on #1099.
npm run test
andnpm run test:integration
. It can make sense to not run the examples test on the git hooks, and run them only on CI. We could also skip coverage for the guides / examples with a similar technique🚨 Test instructions