Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support istanbul on devchain #1180

Merged
merged 3 commits into from
Jan 7, 2020
Merged

Support istanbul on devchain #1180

merged 3 commits into from
Jan 7, 2020

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Jan 7, 2020

🦅 Pull Request

Add support for hardfork option to devchain.

We use istanbul as default. Other options are: byzantium, constantinople and petersburg.

🚨 Test instructions

Compare gas cost of deploying a token between petersburg and istanbul.

@0xGabi 0xGabi added the 💡 feature update An update to existing functionality of the API label Jan 7, 2020
@0xGabi 0xGabi requested a review from macor161 January 7, 2020 20:30
@codecov
Copy link

codecov bot commented Jan 7, 2020

Codecov Report

Merging #1180 into develop will decrease coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1180      +/-   ##
===========================================
- Coverage     26.9%   26.88%   -0.03%     
===========================================
  Files          122      121       -1     
  Lines         2293     2291       -2     
===========================================
- Hits           617      616       -1     
+ Misses        1676     1675       -1
Impacted Files Coverage Δ
packages/cli/src/commands/devchain_cmds/start.js 0% <ø> (ø) ⬆️
packages/cli/src/commands/run.js 0% <0%> (ø) ⬆️
packages/toolkit/src/ipfs/misc.js 34.14% <0%> (-2.44%) ⬇️
packages/toolkit/src/ipfs/daemon.js 86.66% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c1108e4...33e903b. Read the comment docs.

Copy link
Contributor

@macor161 macor161 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice work 💯

@0xGabi 0xGabi changed the title Support istanbul devchain Support istanbul on devchain Jan 7, 2020
@0xGabi 0xGabi merged commit b99c80a into develop Jan 7, 2020
@0xGabi 0xGabi deleted the support-istanbul-devchain branch January 7, 2020 21:18
@0xGabi 0xGabi added this to the Sprint 1 milestone Jan 7, 2020
@0xGabi 0xGabi self-assigned this Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
💡 feature update An update to existing functionality of the API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants