Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publish with intent #1424

Merged
merged 1 commit into from
Feb 10, 2020
Merged

Fix publish with intent #1424

merged 1 commit into from
Feb 10, 2020

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Feb 10, 2020 •
edited
Loading

🦅 Pull Request Description

After reviewing #1082 I was able to better asses the issue we have with publish with intent and it is only affecting local development.

Rational

Partially address #1150

🚨 Test instructions

aragon apm publish on local should publish interacting with the contract
aragon apm publish on rinkeby should publish with intent

@0xGabi 0xGabi added the 📟 cli A change related with cli tools label Feb 10, 2020
@0xGabi 0xGabi merged commit 7e9a8ee into develop Feb 10, 2020
@0xGabi 0xGabi deleted the publish-intent branch February 10, 2020 20:04
@0xGabi 0xGabi mentioned this pull request Mar 19, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
📟 cli A change related with cli tools
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@0xGabi