Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create-aragon-app: Use new boilerplates #1572

Merged
merged 5 commits into from
Mar 21, 2020
Merged

create-aragon-app: Use new boilerplates #1572

merged 5 commits into from
Mar 21, 2020

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Mar 20, 2020 •
edited
Loading

🦅 Pull Request Description

Default to react boilerplate, remove bare boilerplate and remove inquire prompt

@0xGabi 0xGabi requested a review from macor161 March 20, 2020 23:52
macor161
macor161 approved these changes Mar 21, 2020
View reviewed changes
Copy link
Contributor

@macor161 macor161 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect!! 👌 Only a small question and suggestion.

packages/create-aragon-app/src/commands/create-aragon-app.js Outdated Show resolved Hide resolved
packages/create-aragon-app/src/commands/create-aragon-app.js Show resolved Hide resolved
@0xGabi
Copy link
Contributor Author

0xGabi commented Mar 21, 2020

Thank for fixing the tests 🙏

@macor161 macor161 merged commit 96a5929 into master Mar 21, 2020
@macor161 macor161 deleted the update-boilerplates branch March 21, 2020 00:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macor161 macor161 macor161 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xGabi @macor161