Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add websocket over RPC url global option #1576

Merged
merged 4 commits into from
Mar 22, 2020
Merged

Add websocket over RPC url global option #1576

merged 4 commits into from
Mar 22, 2020

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Mar 22, 2020

🦅 Pull Request Description

Fix #1574

@0xGabi 0xGabi added the 📟 cli A change related with cli tools label Mar 22, 2020
@0xGabi 0xGabi requested review from macor161 and sohkai March 22, 2020 16:31
Copy link
Contributor

@dapplion dapplion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

packages/cli/src/cli.js Outdated Show resolved Hide resolved
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would also be nice to update the warning message that gets printed on some commands—it has a grammar mistake and it would be useful to provide an example there.

A larger warning like this may also be useful to catch attention!

@0xGabi 0xGabi merged commit b84721a into master Mar 22, 2020
@0xGabi 0xGabi deleted the ws-rpc branch March 22, 2020 20:36
@0xGabi 0xGabi mentioned this pull request Mar 22, 2020
@macor161 macor161 mentioned this pull request Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📟 cli A change related with cli tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants