Use wsRpc in dao apps command #1578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xGabi
reviewed
Mar 23, 2020
| @@ -115,7 +116,7 @@ export const handler = async function({ | |||
| task: async (ctx, task) => { | |||
| appsWithoutPermissions = ( | |||
| await getAllApps(daoAddress, { | |||
| web3, | |||
| web3: new Web3(wsProvider || web3.currentProvider), | |||
There was a problem hiding this comment.
Why do we need to initialize a new Web3 object? Shouldn't be the same as line 107 🤔
There was a problem hiding this comment.
Good question. Because the ensureWeb3() function that generates the Web3 object doesn't use wsProvider. I think this has been refactored in develop but not yet on master
0xGabi
approved these changes
Mar 27, 2020
This was referenced Mar 27, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦅 Pull Request Description
Rational
The wsRpc provider wasn't used to fetch permissionless apps.