Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix typo on newDao #1670

Merged
merged 2 commits into from
May 13, 2020
Merged

Fix typo on newDao #1670

merged 2 commits into from
May 13, 2020

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented May 12, 2020

🦅 Pull Request Description

Fix a typo.

Rational

🚨 Test instructions

✔️ PR Todo

  • Include links to related issues/PRs
  • Update unit tests for this change
  • Update the relevant documentation
  • Clear dependencies on other modules that have to be released before merging this

@welcome
Copy link

welcome bot commented May 12, 2020

Thanks for opening this pull request! Someone will review it soon 🔍

@macor161 macor161 self-requested a review May 13, 2020 03:09
macor161
macor161 approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@macor161 macor161 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks @Evalir!

@macor161 macor161 self-requested a review May 13, 2020 03:18
macor161
macor161 approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@macor161 macor161 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot @Evalir! I added param. in front of the parameters to be in accordance with the JSDoc destructuring parameters.

@macor161 macor161 merged commit 93ee114 into master May 13, 2020
@welcome
Copy link

welcome bot commented May 13, 2020

Congrats on merging your first pull request! Aragon is proud of you 🦅
Eagle gif

@macor161 macor161 deleted the fix-newdao-jsdoc branch May 13, 2020 03:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macor161 macor161 macor161 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Evalir @macor161