Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to yargs 12 #248

Closed
wants to merge 8 commits into from
+126 −118
Closed

update to yargs 12 #248

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
250c6fa
update to yargs 12
ewingrj Oct 23, 2018
ce5ec3d
resolve conflicts
0xGabi Jan 13, 2019
2c584c9
Merge branch 'perissology-yargs'
0xGabi Jan 13, 2019
34214a6
Merge remote-tracking branch 'upstream/master'
0xGabi Jan 16, 2019
0d28c15
Merge remote-tracking branch 'upstream/master'
0xGabi Jan 17, 2019
ce1b6b1
minor release
0xGabi Jan 17, 2019
0bc2597
Merge remote-tracking branch 'upstream/master'
0xGabi Jan 17, 2019
b7563ff
remove middlewares from token and dao commands
0xGabi Jan 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 1 addition & 18 deletions src/commands/dao_cmds/acl.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,28 +1,11 @@
const viewCommand = require('./acl_cmds/view')

const {
manifestMiddleware,
moduleMiddleware,
environmentMiddleware,
} = require('../../middleware')

const MIDDLEWARES = [
manifestMiddleware,
moduleMiddleware,
environmentMiddleware,
]

exports.command = 'acl <dao>'

exports.describe = 'Shortcut for aragon dao acl view <dao>'

exports.builder = function(yargs) {
return yargs.commandDir('acl_cmds', {
visit: cmd => {
cmd.middlewares = MIDDLEWARES
return cmd
},
})
return yargs.commandDir('acl_cmds')
}

exports.handler = viewCommand.handler
23 changes: 3 additions & 20 deletions src/commands/dao_cmds/token.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,26 +1,9 @@
const {
manifestMiddleware,
moduleMiddleware,
environmentMiddleware,
} = require('../../middleware')

const MIDDLEWARES = [
manifestMiddleware,
moduleMiddleware,
environmentMiddleware,
]

exports.command = 'token <command>'

exports.describe = 'Create and interact with MiniMe tokens'

exports.builder = function(yargs) {
return yargs
.commandDir('token_cmds', {
visit: cmd => {
cmd.middlewares = MIDDLEWARES
return cmd
},
})
.demandCommand(1, 'You need to specify a command')
const cmd = yargs.commandDir('token_cmds')
cmd.demandCommand(1, 'You need to specify a command')
return cmd
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make this a bit cleaner, since yargs always uses the builder pattern, is:

return yargs
  .commandDir('token_cmds')
  .demandCommand(1, 'You need to specify a command')

}