check for existing transactionPath in execHandler #385
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tryFindTransactionPath
was sometimes being called aftersendTransaction
resolved, which would clear ctx.transactionPath causing the reporter outputctx.transactionPath[0].description
to failfixes this error I was getting in the reporter output (after successful transaction) using the
aragon dao acl create
command:Seemed like the lowest impact fix .. but might be better to clean up the promise code to avoid a race condition like this