Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for existing transactionPath in execHandler #385

Merged
merged 1 commit into from
Aug 7, 2019

Conversation

mikec
Copy link
Contributor

@mikec mikec commented Feb 28, 2019

tryFindTransactionPath was sometimes being called after sendTransaction resolved, which would clear ctx.transactionPath causing the reporter output ctx.transactionPath[0].description to fail

fixes this error I was getting in the reporter output (after successful transaction) using the aragon dao acl create command:

Sending transaction [started]
→ Waiting for transaction to be mined...
Sending transaction [completed]
 ✖ Cannot read property 'description' of undefined

Seemed like the lowest impact fix .. but might be better to clean up the promise code to avoid a race condition like this

`tryFindTransactionPath` was sometimes being called after `sendTransaction` resolved, which would clear ctx.transactionPath causing the reporter output `ctx.transactionPath[0].description` to fail
@mikec mikec force-pushed the tx-path-override-fix branch from 9a59110 to 4d9e352 Compare February 28, 2019 16:16
@stale
Copy link

stale bot commented Jun 23, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for contributing to Aragon! 🦅

@stale stale bot added the abandoned label Jun 23, 2019
@sohkai
Copy link
Contributor

sohkai commented Jun 27, 2019

Please keep this open 😄

@stale stale bot removed the abandoned label Jun 27, 2019
@stale
Copy link

stale bot commented Jul 27, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for contributing to Aragon! 🦅

@stale stale bot added the abandoned label Jul 27, 2019
@0xGabi 0xGabi removed the abandoned label Jul 27, 2019
@0xGabi 0xGabi merged commit 459eca1 into aragon:master Aug 7, 2019
@0xGabi 0xGabi mentioned this pull request Aug 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants