Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle Aragon gateway on environment middleware #455

Merged
merged 1 commit into from
Jun 12, 2019
Merged

Handle Aragon gateway on environment middleware #455

merged 1 commit into from
Jun 12, 2019

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented May 4, 2019 •
edited
Loading

🦅 Pull Request

@0xGabi 0xGabi requested a review from kernelwhisperer as a code owner May 4, 2019 16:22
@0xGabi 0xGabi changed the title Update default ipfs node and timeout [WIP] Update default ipfs node and timeout May 15, 2019
@0xGabi 0xGabi force-pushed the fix/artifact-not-found branch from 609f918 to 4da7fbe Compare June 10, 2019 02:16
@0xGabi 0xGabi added the 🚀 new feature A change that adds new functionality to the API label Jun 10, 2019
@0xGabi 0xGabi changed the title [WIP] Update default ipfs node and timeout Handle Aragon gateway on environment middleware Jun 10, 2019
@0xGabi 0xGabi merged commit 4bc4f36 into aragon:master Jun 12, 2019
@0xGabi 0xGabi deleted the fix/artifact-not-found branch June 12, 2019 06:13
@kernelwhisperer
Copy link
Contributor

Let's add a comment in the code on how this magic works 😄

E.g.:

We check for the registry property on the environment to determine whether the environment is localhost or not. When we are not running locally we change the default ipfs rpc to the aragon gateway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kernelwhisperer kernelwhisperer Awaiting requested review from kernelwhisperer

Assignees
No one assigned
Labels
🚀 new feature A change that adds new functionality to the API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xGabi @kernelwhisperer