Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add coveralls #493

Merged
merged 7 commits into from
Jun 6, 2019
Merged

Add coveralls #493

merged 7 commits into from
Jun 6, 2019

Conversation

kernelwhisperer
Copy link
Contributor

@kernelwhisperer kernelwhisperer commented May 31, 2019 •
edited
Loading

🦅 Pull Request

  • Integrate coveralls, closes Setup code coverage #447
  • Rename @aragon/cli-e2e-tests to @aragon/e2e-tests (this is a private package, no reason to be verbose)
  • Extract the e2e test command

🚨 Test instructions

See: https://coveralls.io/github/aragon/aragon-cli

✔️ PR Todo

  • Include links to related issues/PRs
  • Update unit tests for this change
  • Update the relevant documentation
  • Clear dependencies on other modules that have to be released before merging this

@kernelwhisperer kernelwhisperer marked this pull request as ready for review May 31, 2019 17:23
@kernelwhisperer kernelwhisperer requested a review from 0xGabi as a code owner May 31, 2019 17:23
0xGabi
0xGabi approved these changes Jun 2, 2019
View reviewed changes
Copy link
Contributor

@0xGabi 0xGabi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great addition, one step closer to achieve testing 🎉

Is it possible to ignore folders like config on aragon-cli?

@kernelwhisperer kernelwhisperer merged commit a3e8282 into master Jun 6, 2019
@delete-merged-branch delete-merged-branch bot deleted the add-coveralls branch June 6, 2019 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xGabi 0xGabi 0xGabi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Setup code coverage
2 participants
@kernelwhisperer @0xGabi