Set-up Continuous Deployment #513
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- @aragon/[email protected] - [email protected]
|
Ready for review, feel free to merge as well @0xGabi |
sohkai
reviewed
Jun 27, 2019
|
|
||
| This hook runs after the build and testing steps have finished, and is purpose is twofold: | ||
|
|
||
| 1. Clean-up uncommitted changes resulted from installing or building, e.g.: lockfiles |
There was a problem hiding this comment.
Technically the git stash probably isn't necessary, since npm uses the .gitignore by default and it's unlikely travis will have changed any commits that could be tracked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦅 Pull Request
Closes #401
I think we might have a problem though: the tags on this branch will get removed when we squash and merge...Perhaps if we have only one commit is not an issue.
🚨 Test instructions
✔️ PR Todo