Fix e2e test setup #545
Fix e2e test setup #545
Conversation
0xGabi
added
the
🛠️ toolkit
kernelwhisperer
force-pushed
the
refactor-e2e-test
branch
from
d864f97 to
674c6ec
Compare
kernelwhisperer
force-pushed
the
refactor-e2e-test
branch
from
10dfddf to
f30475c
Compare
| @@ -129,14 +129,13 @@ function sanityCheck( | |||
| modulePath, | |||
| artifact | |||
| ) { | |||
| const { environments, contractPath } = artifact | |||
| const { appName, registry, network } = environments[0] | |||
There was a problem hiding this comment.
It was failing here because environments is not an array.
That being said environments['default'] does not feel alright either.
| }) | ||
|
|
||
| test('should publish an aragon app directory successfully', async t => { | ||
| test.skip('should publish an aragon app directory successfully', async t => { |
There was a problem hiding this comment.
I've marked it to be skipped because, even though it passes, it makes aragon run fail: Cannot find transaction pathing.
Not sure if it's possible to resolve this conflict, but perhaps we shouldn't test deploying to the local devchain since aragon run is already doing it. Can we try deploying to rinkeby instead?
There was a problem hiding this comment.
I tried to use Rinkeby and is working fine but I'm also having problems with Cannot find transaction pathing on some node versions. I'll keep the .skip and merge it
There was a problem hiding this comment.
Oh, I see, it's the same issue as with local host:
It cannot find the transaction path when another deploy is happening at the same time.
Any thoughts @sohkai ?
0xGabi
force-pushed
the
refactor-e2e-test
branch
from
bc23c77 to
2da5bbc
Compare
|
LGTM! |
🦅 Pull Request
Update to fix the problem of two test trying to spawn
aragon devchain