Output publish information before publishing #574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xGabi
added
cmd: apm publish
💡 feature update
kernelwhisperer
suggested changes
Jul 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦅 Pull Request
close #512
To display the contentURI before publishing it we need to upload files to the provider from the
aragonCLIinstead of encapsulate that functionality onapm.js.✔️ PR Todo
Update
apm.jsfunctionpublishVersionIntentto receive a contentURI instead of aprovideranddirectoryInclude links to related issues/PRs
Update unit tests for this change
Note: Include a refactor of the ZERO_ADDRESS and a small change to start IPFS for
ipfs viewandipfs propagatecommands.