Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use a pre build of the client instead of building it every time #764

Merged
merged 3 commits into from
Sep 12, 2019
Merged

Use a pre build of the client instead of building it every time #764

merged 3 commits into from
Sep 12, 2019

Conversation

0xGabi
Copy link
Contributor

@0xGabi 0xGabi commented Sep 11, 2019 •
edited
Loading

🦅 Pull Request

closes #301

aragon start now fetch the client from aragen IPFS cache.

Otherwise if a --client-version (commit hash on aragon/aragon repo) is pass the command will:

  1. Download the new client (skipped if available)
  2. Install dependencies (skipped if available)
  3. Build the client with the build:local script (skipped if available)
  4. Start server & Open the client

Note: If client-version is available the client will be serve from the pre build instead of been build every time

@0xGabi 0xGabi added cmd: start 💡 feature update An update to existing functionality of the API labels Sep 11, 2019
@0xGabi 0xGabi mentioned this pull request Sep 11, 2019
Closed
1 task
@0xGabi 0xGabi merged commit 92c6063 into aragon:master Sep 12, 2019
@0xGabi 0xGabi deleted the prebuild-client branch September 12, 2019 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kernelwhisperer kernelwhisperer Awaiting requested review from kernelwhisperer

Assignees
No one assigned
Labels
💡 feature update An update to existing functionality of the API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create pre-packaged build of client
1 participant
@0xGabi