Removes hardcoded contract ABIs #837
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macor161
reviewed
Oct 29, 2019
macor161
reviewed
Oct 29, 2019
| @@ -45,6 +45,7 @@ | |||
| "@aragon/apps-shared-minime": "^1.0.1", | |||
| "@aragon/aragen": "^5.0.0", | |||
| "@aragon/cli-utils": "^0.0.8", | |||
| "@aragon/id": "^2.1.0", | |||
| "@aragon/truffle-config-v4": "^1.0.0", | |||
There was a problem hiding this comment.
We should probably add the @aragon/os dependency here
Suggested change
| "@aragon/truffle-config-v4": "^1.0.0", | |
| "@aragon/os": "^4.3.0", | |
| "@aragon/truffle-config-v4": "^1.0.0", |
|
@ajsantander this PR have a lot of duplications from #833 I think we should merge them or decide which one to include. Note: I like the name standardization that @dapplion included. Probably we want to keep that part. |
6 tasks
4 tasks
|
We can close this PR as it will be replaced by #833 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #818
While doing this, I saw that there are a lot of manual
new web3.ethContract(abi, address)usages. I suggest that we open a new issue to add a "getContract" helper, similar to what already exists in utils.js but capable of retrieving a full Web3 Contract instance.