Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add development network to truffle config #529

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Add development network to truffle config #529

merged 2 commits into from
Jul 3, 2019

Conversation

haythemsellami
Copy link
Contributor

Fixes #319

@coveralls
Copy link

coveralls commented May 20, 2019

Coverage Status

Coverage remained the same at 99.542% when pulling e2abf39 on haythem96:add-development-network into d10d195 on aragon:dev.

@sohkai
Copy link
Contributor

sohkai commented May 21, 2019

Hmm, actually I'm not sure what parameters we should use. I noticed in aragon-react-boilerplate that it uses 8545 (the default), but sets network_id: *, as I believe we use a random ID for aragon devchain.

cc @0x6431346e @0xGabi.

@kernelwhisperer
Copy link

Hmm, actually I'm not sure what parameters we should use. I noticed in aragon-react-boilerplate that it uses 8545 (the default), but sets network_id: *, as I believe we use a random ID for aragon devchain.

cc @0x6431346e @0xGabi.

Yes, that's why.

@sohkai
Copy link
Contributor

sohkai commented Jul 3, 2019

@haythem96 Thanks for updating this!

@sohkai sohkai merged commit cfb113d into aragon:dev Jul 3, 2019
@welcome
Copy link

welcome bot commented Jul 3, 2019

Congrats on merging your first pull request! Aragon is proud of you 🦅
Eagle gif

@haythemsellami haythemsellami deleted the add-development-network branch July 3, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add development network to truffle config
4 participants