Apps: orphan app WebWorkers' origins #797
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bpierre
reviewed
May 27, 2019
src/aragonjs-wrapper.js
Outdated
| workerUrl = await getBlobUrl(scriptUrl) | ||
| // have to fetch the script (from an IPFS gateway) and process it locally | ||
| // Note that we **HAVE** to use a data url, to ensure the Worker is | ||
| // created with an opaque origin |
There was a problem hiding this comment.
Maybe we could also add here why we need an opaque origin, using the indexedDB access as an example?
bpierre
approved these changes
May 27, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Orphans app WebWorkers to an opaque origin. Trying to access
indexedDBnow results in an error:This wasn't a huge issue before, as WebWorkers have no access to
localStorageor the DOM, but after we introducedlocalForageandindexedDBaccess, these WebWorkers all of a sudden were able to Do Bad ThingsTM (like write to an app's cache at will and influence another app's frontend).Also gives the WebWorkers some names, for ease of debugging: