-
Notifications
You must be signed in to change notification settings - Fork 273
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HelpScout suggestions #804
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, a couple small comments and a slightly annoying / confusing thing when you opt-in.
2ca486d
to
34ef602
Compare
Hey @AquiGorka, I was reviewing these changes and I have a quick question – technically speaking, could we remove the hyperlink styling from the suggested content titles? Or perhaps we could actually open a new tab with the wiki on the anchored section. (We should not redirect users to the wiki from the same page though). At the moment, the titles and images behave as links but nothing happens on click. |
I think we can remove those links, but @john-light is the person responsible since that's the content itself |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Maybe we could pass an HTTP (since HelpScout relies on HTTP already) URL as an environment variable, where a JSON equivalent of |
Thought of using the raw file from this same repo for that purpose, too centralized no? |
Ah yes we could do that! Using HelpScout is centralized already, and users have to opt-in, so I don’t think it would be a big issue to also load this from GitHub. |
The links have been intentionally left in place on HelpScout so that specific sub-sections of the docs can be linked into. |
The following suggestions have been applied (there is a max 5 items limit on suggestions):
@luisivan and @john-light let me know if this is fine or if this needs to be modified.
For the time being these changes make it necessary to deploy in case we want to update the suggestions mapped to a section. This works if we want to quickly publish this out there but for the long run we need another solution that'll make it easy to update suggestions. Pinging @bpierre and @sohkai for ideas here.