Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HelpScout suggestions #804

Merged
merged 19 commits into from
May 29, 2019
Merged

HelpScout suggestions #804

merged 19 commits into from
May 29, 2019

Conversation

AquiGorka
Copy link
Contributor

@AquiGorka AquiGorka commented May 27, 2019

The following suggestions have been applied (there is a max 5 items limit on suggestions):

  • Home
    • Home
    • Troubleshoot tips
    • About Aragon apps
    • Anatomy of an Aragon organization
    • About Aragon
  • Token Manager
    • Token Manager
    • About Aragon
  • Voting
    • Voting
    • About Aragon
  • Finance
    • Finance
    • About Aragon
  • Permissions
    • Permissions
    • About Aragon
  • App Center
    • App Center
    • About Aragon
  • Settings
    • Settings
    • About Aragon
  • Onboarding
    • Prerequisites
    • About templates
    • Create a new Democracy organization
    • Create a Multisig organization
    • About Aragon

@luisivan and @john-light let me know if this is fine or if this needs to be modified.

For the time being these changes make it necessary to deploy in case we want to update the suggestions mapped to a section. This works if we want to quickly publish this out there but for the long run we need another solution that'll make it easy to update suggestions. Pinging @bpierre and @sohkai for ideas here.

@AquiGorka AquiGorka requested review from sohkai and bpierre and removed request for sohkai May 27, 2019 10:02
@luisivan luisivan mentioned this pull request May 27, 2019
25 tasks
Copy link
Contributor

@sohkai sohkai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a couple small comments and a slightly annoying / confusing thing when you opt-in.

@AquiGorka AquiGorka force-pushed the feature/helpscout-suggest branch from 2ca486d to 34ef602 Compare May 28, 2019 08:33
@dizzypaty
Copy link

Hey @AquiGorka, I was reviewing these changes and I have a quick question – technically speaking, could we remove the hyperlink styling from the suggested content titles? Or perhaps we could actually open a new tab with the wiki on the anchored section. (We should not redirect users to the wiki from the same page though).

At the moment, the titles and images behave as links but nothing happens on click.

Group

Screen Shot 2019-05-28 at 19 03 41

@luisivan
Copy link
Contributor

I think we can remove those links, but @john-light is the person responsible since that's the content itself

@AquiGorka AquiGorka requested a review from sohkai May 29, 2019 07:15
@AquiGorka AquiGorka requested review from bpierre and removed request for bpierre May 29, 2019 07:15
Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@bpierre
Copy link
Contributor

bpierre commented May 29, 2019

For the time being these changes make it necessary to deploy in case we want to update the suggestions mapped to a section. This works if we want to quickly publish this out there but for the long run we need another solution that'll make it easy to update suggestions. Pinging @bpierre and @sohkai for ideas here.

Maybe we could pass an HTTP (since HelpScout relies on HTTP already) URL as an environment variable, where a JSON equivalent of suggestions.js could be fetched from?

@AquiGorka
Copy link
Contributor Author

Thought of using the raw file from this same repo for that purpose, too centralized no?

@AquiGorka AquiGorka merged commit cffe843 into master May 29, 2019
@AquiGorka AquiGorka deleted the feature/helpscout-suggest branch May 29, 2019 14:00
@bpierre
Copy link
Contributor

bpierre commented May 29, 2019

Thought of using the raw file from this same repo for that purpose, too centralized no?

Ah yes we could do that! Using HelpScout is centralized already, and users have to opt-in, so I don’t think it would be a big issue to also load this from GitHub.

@john-light
Copy link
Contributor

I think we can remove those links, but @john-light is the person responsible since that's the content itself

The links have been intentionally left in place on HelpScout so that specific sub-sections of the docs can be linked into.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants