Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Subgraph: Update event for schedule along with handlers #202

Merged
merged 8 commits into from
Nov 6, 2020

Conversation

Evalir
Copy link
Contributor

@Evalir Evalir commented Nov 5, 2020

No description provided.

Comment on lines 65 to 66
let config = ConfigEntity.load(queue.config)
let scheduleDeposit = CollateralEntity.load(config.scheduleDeposit)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was thinking of creating loadOrCreate helper here... but these entities relies on values that can't be left null. If we want to still create helpers, we should just raise an error.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes throwing an error sounds good 👍

Copy link
Contributor

@bpierre bpierre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

README.md Outdated Show resolved Hide resolved
docs/developers/historical-deployments.md Outdated Show resolved Hide resolved
Comment on lines 65 to 66
let config = ConfigEntity.load(queue.config)
let scheduleDeposit = CollateralEntity.load(config.scheduleDeposit)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes throwing an error sounds good 👍

@codecov-io
Copy link

codecov-io commented Nov 6, 2020

Codecov Report

Merging #202 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #202   +/-   ##
=======================================
  Coverage   41.07%   41.07%           
=======================================
  Files          17       17           
  Lines         353      353           
  Branches       33       33           
=======================================
  Hits          145      145           
  Misses        208      208           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 71b3fec...e6bdf62. Read the comment docs.

@Evalir Evalir merged commit 4720d31 into master Nov 6, 2020
@Evalir Evalir deleted the fix-subgraph-build branch November 6, 2020 05:25
Comment on lines +11 to +17
export function buildEventHandlerId(
containerHash: string,
eventName: string,
logIndex: string
): string {
return containerHash + logIndex.toString()
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Evalir Should we just pass the container hash + the event directly as a second parameter, to make the calls shorter?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants