-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subgraph: Update event for schedule along with handlers #202
Conversation
let config = ConfigEntity.load(queue.config) | ||
let scheduleDeposit = CollateralEntity.load(config.scheduleDeposit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking of creating loadOrCreate
helper here... but these entities relies on values that can't be left null
. If we want to still create helpers, we should just raise an error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes throwing an error sounds good 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
let config = ConfigEntity.load(queue.config) | ||
let scheduleDeposit = CollateralEntity.load(config.scheduleDeposit) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes throwing an error sounds good 👍
Codecov Report
@@ Coverage Diff @@
## master #202 +/- ##
=======================================
Coverage 41.07% 41.07%
=======================================
Files 17 17
Lines 353 353
Branches 33 33
=======================================
Hits 145 145
Misses 208 208 Continue to review full report at Codecov.
|
Co-authored-by: Pierre Bertet <[email protected]>
…into fix-subgraph-build
export function buildEventHandlerId( | ||
containerHash: string, | ||
eventName: string, | ||
logIndex: string | ||
): string { | ||
return containerHash + logIndex.toString() | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Evalir Should we just pass the container hash + the event directly as a second parameter, to make the calls shorter?
No description provided.