Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix edit button for CLI and JS docs #137

Merged
merged 7 commits into from
Apr 22, 2019
Merged

Conversation

kernelwhisperer
Copy link
Contributor

@kernelwhisperer kernelwhisperer commented Apr 19, 2019

Removed the file from git ignore so they can be edited.
Closes #134

TODO:

.gitignore Outdated
@@ -14,9 +14,5 @@ website/i18n/*
website/static/aragon-ui
website/*.lock

# ignore files generated from repos
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe is better to allow edits on one place

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe is better to allow edits on one place

Definitely, nice catch with the custom_edit_url option!

@kernelwhisperer kernelwhisperer force-pushed the fix-edit-for-cli-and-js branch from 887abe6 to c0480c0 Compare April 21, 2019 10:18
@kernelwhisperer
Copy link
Contributor Author

Ready for review again

@0xGabi 0xGabi self-requested a review April 22, 2019 04:50
@kernelwhisperer kernelwhisperer merged commit eb1ae92 into master Apr 22, 2019
@kernelwhisperer kernelwhisperer deleted the fix-edit-for-cli-and-js branch April 22, 2019 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit button on generated docs are broken
2 participants