Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hello world to tutorial #21

Merged
merged 1 commit into from
Aug 30, 2018
Merged

Add hello world to tutorial #21

merged 1 commit into from
Aug 30, 2018

Conversation

jtremback
Copy link
Contributor

@jtremback jtremback commented Jun 22, 2018

Close #20

@CLAassistant
Copy link

CLAassistant commented Jun 22, 2018

CLA assistant check
Thank you for your submission, we really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

@izqui izqui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution, this will definitely help! Just a couple of details, and as soon as the CLA is accepted by you, we can merge.

npm i -g @aragon/cli
aragon init foo.aragonpm.eth react
cd foo
npm install
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained aragon/aragon-cli#148 (comment), npm install shouldn't be required as it is already performed by the init command.

aragon init foo.aragonpm.eth react
cd foo
npm install
npm start
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would substitute npm start with aragon run to be consistent with the rest of the documentation.

@luisivan
Copy link
Contributor

Applied all changes by @izqui

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants