Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fixes check tag to ignore semver additions #42

Merged
merged 5 commits into from
Jan 11, 2024
Merged

ci: fixes check tag to ignore semver additions #42

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
751ba5c
ci: fixes check tag to ignore semver additions
mathewmeconry Jan 11, 2024
accfec9
ci: checktag better fix
mathewmeconry Jan 11, 2024
e292058
ci: check tag removes useless grep command
mathewmeconry Jan 11, 2024
740afa0
ci: checktag updates comments
mathewmeconry Jan 11, 2024
d751a4a
ci: checktag corrects title
mathewmeconry Jan 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/reusable-check-tag.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,6 @@ jobs:
GITHUB_REF="${{ inputs.ref }}"
TAG=${GITHUB_REF##*/}
VERSION=$(echo "$TAG" | grep -woP "([0-9]+\.[0-9]+\.[0-9]+)-\w+" | sed -E 's/-(sdk|subgraph|contracts|configs)//')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please write a comment what the commands are doing.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was already there but improved with the latest commit

PACKAGE=$(echo "$TAG" | grep -oP -- "-.*" | sed -E "s/-//")
PACKAGE=${TAG##*-}
echo "package=$PACKAGE" >> $GITHUB_OUTPUT
echo "version=$VERSION" >> $GITHUB_OUTPUT