Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: zksync network configuration #86

Merged
merged 7 commits into from
May 21, 2024

Conversation

clauBv23
Copy link
Contributor

@clauBv23 clauBv23 commented May 21, 2024

Description

Fixes the errors on the PR adding the zksync network.
We should either merge #85 before or just keep this one.

Task ID: OS-No-ref

Checklist:

  • I have selected the correct base branch.
  • I have performed a self-review of my own code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have made corresponding changes to the documentation.
  • My changes generate no new warnings.
  • Any dependent changes have been merged and published in downstream modules.
  • I created tasks to update dependent repositories (OSx, Plugins)
  • I ran all tests with success and extended them if necessary.
  • I have updated the CHANGELOG.md file in the root folder.

Copy link
Contributor

@josemarinas josemarinas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work please update the version in the package.json file, update the changelog and add the deployment tag so we deploy versiojn 0.5.0

@clauBv23
Copy link
Contributor Author

clauBv23 commented May 21, 2024

@josemarinas done!

still, I think the way to go should be:

otherwise, we will have a release version that is not on the main branch

@clauBv23 clauBv23 marked this pull request as ready for review May 21, 2024 10:01
@clauBv23 clauBv23 requested a review from josemarinas May 21, 2024 10:01
@clauBv23 clauBv23 changed the title fix: zksync agregation fix: zksync network configuration May 21, 2024
@clauBv23 clauBv23 requested review from Rekard0 and novaknole May 21, 2024 10:02
@novaknole novaknole merged commit eef4130 into feature/zksync-era-sepolia-support May 21, 2024
5 checks passed
@novaknole novaknole deleted the fix/zksync-agregation branch May 21, 2024 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants